chore(rhdh-operator): update branch protection rules#81092
Conversation
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
WalkthroughThe branch protection config for ChangesBranch protection check updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml`:
- Around line 15-16: The required status checks in the Prow config include
contexts that are not produced anywhere in this repo, so update the
_prowconfig.yaml entry for required_status_checks.contexts to remove “Validate
Dockerfile” and “Validate Bundle Manifests” unless you also add matching jobs
under ci-operator/config/redhat-developer/rhdh-operator/. If these are meant to
be conditional validations, move them to required-if-present-contexts instead so
they do not block merges when no job exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 38723b32-4e9c-4c7b-b807-628acada1cdf
📒 Files selected for processing (1)
core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
|
@rm3l: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l, subhashkhileri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@rm3l: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
2 participants
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
Otherwise, all PRs (example) against main are blocked due to this branch protection rule automatically sync'ed and enforced in the rhdh-operator repo settings. "PR Publish" will never be triggered:
Summary by CodeRabbit
Updated the
rhdh-operatorCI branch protection configuration to reflect the current supported branches and job names. This removes protection rules for the unmaintained1.2.x,release-1.3, andrelease-1.4branches, and adjusts themainbranch required checks so merges now depend on the latest validation jobs (PR Validate,Validate Dockerfile, andValidate Bundle Manifests) instead of the olderPR Publishcheck.